Cacti / cacti

Cacti ™
http://www.cacti.net
GNU General Public License v2.0
1.63k stars 405 forks source link

RRDfile Cleaner error with v1.12.14 #3872

Closed oijkn closed 3 years ago

oijkn commented 3 years ago

Describe the bug

Using the utilities RRDfile Cleaner function from the GUI does not remove automatically the RRD files.

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Utilities->System Utilities->RRDfile Cleaner'

  2. Click on 'Rescan->Delete All'

Expected behavior

This function is supposed to delete the RRD files not used by the graphs but the deletion is not done correctly.

Screenshots

image

Desktop (please complete the following information)

Thank you for your support.

BR

TheWitness commented 3 years ago

Pretty sure that this is fixed in the 1.2.x branch already. Update your poller_maintenance.php from the 1.2.x branch and test.

oijkn commented 3 years ago

I've updated the poller_maintenance.php from the 1.2.X branch and now the error is in another line. After checking in my server, the RRD files are not deleted immediately when I click on delete button (maybe this is done during the polling cycle).

image

TheWitness commented 3 years ago

Okay, cool. The files are staged for removal, and removed during the next poller cycle by default.

TheWitness commented 3 years ago

Well, you are not on the 1.2.x branch but something else. So, slow down a little. You can do this from your shell (assuming /var/www/html):

cd /var/www/html
git clone -b 1.2.x https://github.com/Cacti/cacti.git some_directory
cp -p some_directory/poller_maintenance.php /var/www/html/cacti
oijkn commented 3 years ago

Indeed you were right, by doing the manipulation directly from the shell I don't see any more error message in the logs, well done thank you !