Ping Result not reported properly

[carryel]

Describe the bug

cacti version is develop branch.

Ping Result was always "ICMP ping Timed out" even though the server was alive.

When debugging this issue, the parsing of the results appeared to be incorrect.

• PHP_OS was "Linux".
• ping command was "fping -q -t 400 -c 1 -r 1 my.host.com".
• Result was "my.host.com : xmt/rcv/%loss = 1/1/0%, min/avg/max = 0.258/0.258/0.258".

It seems to be a side-effect of https://github.com/Cacti/cacti/commit/011ae4c5c53a65d3a6ff077ed66601d79112af4e#diff-22abb1862abff566f5588ec6a9666d11553d088d2bb54a280a7b21b2ca36b499R225 .

I think the "if statement" should be reversed like this:

if (strtoupper(substr(PHP_OS, 0, 3)) !== 'WIN') {

https://github.com/Cacti/cacti/blob/develop/lib/ping.php#L225

To Reproduce

Steps to reproduce the behavior:

1. Go to '...'

2. Click on '....'

3. Scroll down to '....'

4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

Desktop (please complete the following information)

• OS: CentOS7

Additional context

Add any other context about the problem here.

[sgvfr]

Also experiancing the same results with commits after https://github.com/Cacti/cacti/commit/011ae4c5c53a65d3a6ff077ed66601d79112af4e

Advanced ping template stops graphing all hosts.. git reset --hard 4563aaa1d resolves it for me.

[arno-st]

Same here, but didn't do the troubleshooting. Except that the ping is OK for spine, and in CLI, but on the dipslay it said ping timeout. I'm using icmp ping and SNMP uptime to get the status and the device is UP as it should be, with the ping timeout error. Cacti dev branch, On almalinux

[TheWitness]

Okay, fixed this. No changelog as this was between releases. Thanks for reporting all!