search

Cacti / cacti

Cacti ™
http://www.cacti.net
GNU General Public License v2.0
1.6k stars 398 forks source link

Fix cli scripts #5729

Closed xmacan closed 2 months ago

xmacan commented 2 months ago

Script change_device.php has error: PHP Warning: Undefined array key "ip" in /usr/local/share/cacti_develop/cli/change_device.php on line 370 In scripts is used variable $ip instead of $hostname. I don't want to change it. So only small fix.

Script add_device.php - PHP 8 issue. Without define --template=X is $template_id defaulted from settings and it could be string(0) "" It is incorrect compare here: if (!isset($host_templates[$template_id])) { } ERROR: Unknown template id ()

array(2) { [0]=> string(4) "None" [1]=> string(19) "Generic SNMP Device"

xmacan commented 2 months ago

Found more.... wait with approve

xmacan commented 2 months ago

done