Mss970 patch 1 (issue#5776: Undefined array key "description" in file settings.php)

Cacti / cacti

Cacti ™

http://www.cacti.net

GNU General Public License v2.0

1.63k stars 404 forks source link

Mss970 patch 1 (issue#5776: Undefined array key "description" in file settings.php) #5778

Closed MSS970 closed 3 months ago

MSS970 commented 3 months ago

issue#5776: Undefined array key "description" in file settings.php

ERROR PHP WARNING: Undefined array key "description" in file: D:\cacti\apache\htdocs\cacti\settings.php on line: 1221 #5776

The following setting (Tab, Field Name, Field Array) DOES NOT HAVE a 'description' key:

Tab: "alerts" field_name: "thold_notification_delay" method: "hidden" key: friendly_name value: Device Notification Delay Options key: method value: hidden

MSS970 commented 3 months ago

Dear Team, Kindly can you review this change to resolve 2 issues #5780 and #5776

TheWitness commented 3 months ago

Looks good. I'm going to implement just a little differently though as it also impacts 1.2.x. Thanks for the contribution.

TheWitness commented 3 months ago

This is resolved now by the following two commits.

8a58c8f0ec1a4407cd37ac73e9a40b7e5c9d2b6a and f364ec350253e2a74c8922977e4c30946b0cbb20