Cacti / cacti

Cacti ™
http://www.cacti.net
GNU General Public License v2.0
1.65k stars 406 forks source link

1.3 develop - unable to create graph automation rules, I get "One or more fields failed validation" #5916

Open esundberg opened 2 days ago

esundberg commented 2 days ago

Describe the bug

Trying to have graphs create automatically for devices. Specificallt traffic 95%

To Reproduce

Steps to reproduce the behavior: Automation > Graph Rules >"Traffic Graphs" rules I created Name: Traffic Graphs Data Query: SNMP - Interface Statistics Graph Type: In/Out (64-bit, 95th)

Then I click + to add a Device Selection Criteria Operation: leave blank Field Name: H: snmp_sysName - varchar(300) Operator: contains Matching Pattern: SEA1 <<<< For our Router CR1.SEA1 Sequence is set to 1 by cacti

When click create I get "One or more fields failed validation"

Screenshots

image

Desktop (please complete the following information)

Additional context

Cacti logs shows...

2024-11-12 22:08:44 - ERROR PHP WARNING: Undefined array key "name" in file: /var/www/html/cacti/lib/api_automation.php  on line: 2437
2024-11-12 22:08:44 - PHP ERROR WARNING Backtrace:  (/automation_graph_rules.php[83]:automation_graph_rules_item_edit(), /automation_graph_rules.php[529]:global_item_edit(), /lib/api_automation.php[2437]:CactiErrorHandler())
2024-11-12 22:08:44 - CMDPHP ERROR: A DB Row Failed!, Error: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'AND rule_type=1' at line 1
2024-11-12 22:08:44 - SQL Backtrace:  (/automation_graph_rules.php[83]:automation_graph_rules_item_edit(), /automation_graph_rules.php[529]:global_item_edit(), /lib/api_automation.php[2440]:get_sequence(), /lib/functions.php[3890]:db_fetch_row(), /lib/database.php[816]:db_fetch_row_prepared(), /lib/database.php[840]:db_execute_prepared())
2024-11-12 22:08:44 - ERROR PHP WARNING: Trying to access array offset on false in file: /var/www/html/cacti/lib/functions.php  on line: 3894
2024-11-12 22:08:44 - PHP ERROR WARNING Backtrace:  (/automation_graph_rules.php[83]:automation_graph_rules_item_edit(), /automation_graph_rules.php[529]:global_item_edit(), /lib/api_automation.php[2440]:get_sequence(), /lib/functions.php[3894]:CactiErrorHandler())

I ran the database update tool

root@cacti:/var/www/html/cacti/cli# php -q upgrade_database.php 
NOTE: Repairing Tables for Local Database
ERROR: Your Cacti is already up to date
  - from: v1.3.0
      to: v1.3.0 - Dev b94bf9c3 @ 2024-11-12 21:53

Git status

netadmin@cacti:/var/www/html/cacti$ git pull
Already up to date.
netadmin@cacti:/var/www/html/cacti$ git status
On branch develop
Your branch is up to date with 'origin/develop'.

nothing to commit, working tree clean
netadmin@cacti:/var/www/html/cacti$ git log -1
commit b94bf9c3aae514b471a5f56b4eb835366c034d5a (HEAD -> develop, origin/develop, origin/HEAD)
Author: TheWitness <thewitness@cacti.net>
Date:   Mon Nov 11 11:23:23 2024 -0500

    QA: Fix issue with CSRF failing on no method passed
TheWitness commented 1 day ago

I'm not surprised this is broken at the moment. As soon as I get my Cacti IoT/Streams plugin close enough for some people to write some Device Packages, I'll double back on this.