Cacti / cacti

Cacti ™
http://www.cacti.net
GNU General Public License v2.0
1.65k stars 404 forks source link

Improve Speed of Graph Template Editing Through Bulk Updates #5942

Open TheWitness opened 1 day ago

TheWitness commented 1 day ago

Feature Request

Is your feature request related to a problem? Please describe

In a cursory review of the Template modification logic, I ran across a while look doing individual updates from the same row. Seems inefficient. Let's do bulk updates instead.

image

Describe the solution you'd like

Do a simple update for each Graph Item. Since there are so many items, this should speed up Template propagation changes in general.

Describe alternatives you've considered

Stored procedures for less turns.

Additional context

Stored Procedures, something to think about.

TheWitness commented 1 day ago

After reviewing, this will not provide a big speedup as it only impacts the template, but should be done as a single update just to make it faster.