search

Cacti / documentation

Documentation for Cacti, Spine, RRDProxy and more
62 stars 52 forks source link

Adding missing files dev-standards_sql_standards.txt and dev-standard… #26

Closed jpobeda closed 6 years ago

jpobeda commented 6 years ago

Special note: I'm assuming you don't want the subversion file from this link: https://docs.cacti.net/dev_standards:subversion

https://docs.cacti.net/dev_standards:security#security https://docs.cacti.net/dev_standards:sql_standards

netniV commented 6 years ago

Hi Javier,

You will notice I've been at work again.... your new files are not including in the index, so your commit is failing 👎

Travis output:
The command "./check_markdown_style.sh" exited with 0.
0.12s$ ./check_missing_link.sh
Not Linked: Standards-SQL.md
Not Linked: Standards-Security.md
2 unlinked files
The command "./check_missing_link.sh" exited with 2.
jpobeda commented 6 years ago

@netniV you nasty ...I'll fix it in a 5 min

jpobeda commented 6 years ago

Shall we add this extra step to doc standards?

netniV commented 6 years ago

Yeah but I've just done something else, I updated README.md... I think you'll agree with the update, but let me know.

netniV commented 6 years ago

You'll need to do a git rebase after fetching the latest changes, then probably a git push -f from your branch

netniV commented 6 years ago

No, we shouldn't include the SVN page, but we should probably have one for the git pre-commit script I use as it would be useful for others, especially given it would help prevent failures down the line if they are validated earlier.

jpobeda commented 6 years ago

Oh I see...I did wrong again then. Give me a min

netniV commented 6 years ago

No, it was me. I went to fix the typo and thought, this is getting long and messy. It needs SECTIONS! 🤒