search

Cacti / plugin_gexport

Cacti Graph Export Plugin
GNU General Public License v2.0
12 stars 9 forks source link

Changes from forum discussion #42

Closed thrca closed 3 years ago

thrca commented 4 years ago

The first commit fixes the issue when setting max_graphs to 0 (for unlimited) as the function was not checking for that before dumping with error.

The latter commits make the debug logging a bit more concise to figure out what is going on with the export process.

I was able to get the tree view to reproduce the 0.8.8g behavior of creating a directory per tree branch, but this entailed a much more extensive rewrite. Since this wasn't necessary for the mainline branch, I did not add that mess to the PR.

TheWitness commented 4 years ago

@thrca, will you be making the updates that @netniV suggested?

thrca commented 4 years ago

There is still a finite limit to number of graphs before gexport fails, which did not happen in old 0.8.8 (pre-plugin) that I haven't figured out how to solve.. Basically, once we hit some specific number of graphs to export, I believe we run out of memory when adding to the array. I have a heavily modified gexport that has removed a lot of extra stuff, but still suffers the issue, and I haven't had time to figure out how to solve it.

TheWitness commented 4 years ago

We are making a change in 1.2.12 to make the memory limit unlimited for CLI scripts. So, if you test on the 1.2.x branch, you should not have this issue.

TheWitness commented 3 years ago

This is all fixed up for the 2.0 release.