search

Cacti / plugin_mactrack

Mactrack Plugin for Cacti
GNU General Public License v2.0
12 stars 25 forks source link

Fix #82 #130

Closed Susanin63 closed 4 years ago

Susanin63 commented 4 years ago

mac_track_devices and mac_track_device_types don't have unique index on device_id and device_type_id columns. When you edit any device type and change any of (sysDescr_match, sysObjectID_match, `device_type') this will dubl row in table. Need add unique index OR don't use device_type_id on save sql https://github.com/Cacti/plugin_mactrack/blob/77bff4acf78386854ff5f1705b159ce98d2ab115/mactrack_device_types.php#L167

Creating an index is better.

Also this fix #82

TheWitness commented 4 years ago

Thanks for keeping this baby alive!