search

Cacti / plugin_mactrack

Mactrack Plugin for Cacti
GNU General Public License v2.0
12 stars 25 forks source link

Fix MacWatch, Sites - delete problem #144

Closed ArturasJudickas closed 4 years ago

ArturasJudickas commented 4 years ago

Fix $i++; location in files mactrack_macwatch.php and mactrack_sites.php (problem delete records), Correcting visual in files mactrack_device.php and etc.

TheWitness commented 4 years ago

Although technically using the $i variable is not require, at least this will be consistent. Fine and thanks for catching the two bugs.

Before I commit, can you please update the CHANGELOG.md?

ArturasJudickas commented 4 years ago

This is the design syntax I found in the main cacti... Did I update the CHANGELOG.md correctly?

ArturasJudickas commented 4 years ago

2020.10.22 04:30, TheWitness rašė:

Although technically using the $i variable is not require, at least this will be consistent. Fine and thanks for catching the two bugs. This is the design syntax I found in the main cacti...

Before I commit, can you please update the CHANGELOG.md? Did I update the CHANGELOG.md correctly?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Cacti/plugin_mactrack/pull/144#issuecomment-714146530, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARNZJ5J5KQT4SAUSNY6U5G3SL6DL7ANCNFSM4SZ5UVQQ.

TheWitness commented 4 years ago

No, please update the CHANGELOG.md.

ArturasJudickas commented 4 years ago

No, please update the CHANGELOG.md.

Does this mean that you have to write the solution text in CHANGELOG.md file?

144: Fix MacWatch, Sites - delete problem

TheWitness commented 4 years ago

Yup as easy as that. Just push that change into your repo and it'll appear in the pull like magic.

TheWitness commented 4 years ago

Yea, I know. When I edit some of this very old code, I'm like "who the hell wrote that". Most of time it turns out it's me. That's how you evolve as you progress in your career. Sometimes when you look back, you blush.

TheWitness commented 4 years ago

I'm going to merge this, but feel free to do another pull request with your changelog updates. Thanks for helping out too!