search

Cacti / plugin_monitor

Monitor Plugin for Cacti
GNU General Public License v2.0
36 stars 39 forks source link

monitor crash and disabled by cacti with newest commits on develop code. #169

Closed sgvfr closed 6 months ago

sgvfr commented 6 months ago

Describe the bug

commits since 4563aaa1d appear to interfere with pinging all hosts using the advanced ping template and crashes the monitor template (most current develop) Ubuntu LTS PHP 8.1 Cacti 1.3.0 - Dev 4563aaa1 @ 2024-01-27 14:02

reverting back to 4563aaa1d resolves.

New errors in the log after upgrade:

2024-01-27 13:44:10 - CMDPHP ERRORS DETECTED - DISABLING PLUGIN 'monitor'
2024-01-27 13:44:09 - PHP ERROR Backtrace: (CactiShutdownHandler())
2024-01-27 13:44:09 - ERROR PHP ERROR in Plugin 'monitor': Uncaught TypeError: array_key_exists(): Argument Cacti/cacti#2 ($array) must be of type array, null given in /var/www/html/cacti/plugins/monitor/monitor.php:1823 Stack trace: #0 /var/www/html/cacti/plugins/monitor/monitor.php(2220): get_status_icon() Cacti/cacti#1 /var/www/html/cacti/plugins/monitor/monitor.php(1785): render_host_tiles() Cacti/cacti#2 /var/www/html/cacti/plugins/monitor/monitor.php(1318): render_host() Cacti/cacti#3 /var/www/html/cacti/plugins/monitor/monitor.php(244): render_default() Cacti/cacti#4 /var/www/html/cacti/plugins/monitor/monitor.php(161): draw_page() Cacti/cacti#5 {main} thrown in file: /var/www/html/cacti/plugins/monitor/monitor.php on line: 1823
2024-01-27 13:44:09 - PHP ERROR WARNING Backtrace: (/plugins/monitor/monitor.php[161]:draw_page(), /plugins/monitor/monitor.php[244]:render_default(), /plugins/monitor/monitor.php[1318]:render_host(), /plugins/monitor/monitor.php[1785]:render_host_tiles(), /plugins/monitor/monitor.php[2220]:CactiErrorHandler())
2024-01-27 13:44:09 - ERROR PHP WARNING in Plugin 'monitor': Undefined array key "monitor_icon" in file: /var/www/html/cacti/plugins/monitor/monitor.php on line: 2220

reverting to older commit still crashes monitor plugin.

2024-01-27 13:51:59 - SQL Backtrace: (/plugins.php[220]:top_header(), /lib/functions.php[5070]:include_once(), /include/top_header.php[39]:html_show_tabs_left(), /lib/html.php[2022]:api_plugin_hook(), /lib/plugins.php[90]:api_plugin_run_plugin_hook(), /lib/plugins.php[236]:monitor_show_tab(), /plugins/monitor/setup.php[696]:monitor_check_upgrade(), /plugins/monitor/setup.php[190]:db_execute(), /lib/database.php[462]:db_execute_prepared())
2024-01-27 13:51:59 - CMDPHP ERROR: A DB Exec Failed!, Error: Table 'cacti.plugin_monitor_update' doesn't exist
xmacan commented 6 months ago

It was fixed in #164

TheWitness commented 6 months ago

I did some light PSR on this this morning. Did not see your node @xmacan.

xmacan commented 6 months ago

Ok,I will test it again. Give me few minutes

xmacan commented 6 months ago

ok, my bad. I forgot add column to upgrade plugin process. Fixed in #170