Cacti / plugin_npc

Nagios Plugin for Cacti is a complete UI replacement for Nagios fully integrated into Cacti.
GNU General Public License v3.0
4 stars 3 forks source link

Miss 'row_format' definition for four tables with long column index #9

Closed ddb4github closed 4 years ago

ddb4github commented 4 years ago

Describe the bug Miss row_format definition for four tables with long column index

Additional context Prefer code diff

--- a/setup.php
+++ b/setup.php
@@ -405,7 +405,7 @@ function npc_setup_tables() {
                        `configfile_path` varchar(255) NOT NULL default '',
                        PRIMARY KEY  (`configfile_id`),
                        UNIQUE KEY `instance_id` (`instance_id`,`configfile_type`,`configfile_path`))
-                       ENGINE=InnoDB
+                       ENGINE=InnoDB ROW_FORMAT=Dynamic
                        COMMENT='Configuration files';";
        }

@@ -467,7 +467,7 @@ function npc_setup_tables() {
                        `command_args` varchar(255) NOT NULL default '',
                        PRIMARY KEY  (`contact_notificationcommand_id`),
                        UNIQUE KEY `contact_id` (`contact_id`,`notification_type`,`command_object_id`,`command_args`))
-                       ENGINE=InnoDB
+                       ENGINE=InnoDB ROW_FORMAT=Dynamic
                        COMMENT='Contact host and service notification commands';";
        }

@@ -591,7 +591,7 @@ function npc_setup_tables() {
                        PRIMARY KEY  (`customvariable_id`),
                        UNIQUE KEY `object_id_2` (`object_id`,`config_type`,`varname`),
                        KEY `varname` (`varname`))
-                       ENGINE=InnoDB
+                       ENGINE=InnoDB ROW_FORMAT=Dynamic
                        COMMENT='Custom variables';";
        }

@@ -607,7 +607,7 @@ function npc_setup_tables() {
                        PRIMARY KEY  (`customvariablestatus_id`),
                        UNIQUE KEY `object_id_2` (`object_id`,`varname`),
                        KEY `varname` (`varname`))
-                       ENGINE=InnoDB
+                       ENGINE=InnoDB ROW_FORMAT=Dynamic
                        COMMENT='Custom variable status information';";
        }
TheWitness commented 4 years ago

Thanks Jing. I will update. There is another column issue that also rolled in from the forums.

TheWitness commented 4 years ago

Fixed.