When creating a new Report Template, save fails and loses all data

Cacti / plugin_reportit

ReportIt Plugin for Cacti

GNU General Public License v2.0

7 stars 9 forks source link

When creating a new Report Template, save fails and loses all data #41

Closed netniV closed 5 years ago

netniV commented 6 years ago

Given the following configuration:

When clicking Create, you will receive

Therefore, the lock should be applied by default. The only thing I changed to make this save was to click the Locked toggle. Additionally, only Name and Additional Pre-Filter keep their settings as all other entries fields lose their settings as a result of this failure.

ikorzha commented 5 years ago

netniV, I was facing the same issue until i stumbled on your post.. Is there a way you can apply a fix to this problem?

netniV commented 5 years ago

Maybe, but I think the default was removed recently. I will need to double check with @browniebraun on that since he's the creator/master of this ;-)

netniV commented 5 years ago

So, I was right, I did see a change relating to that which was 498a714 which was part of PR #16 by @Carlimeunier but it would appear that the 'locked' change is incorrect. If @browniebraun doesn't have an update, I can look at repairing it.

netniV commented 5 years ago

So I went ahead and readded the automatic 'locked' status. This should now be resolved.

ikorzha commented 5 years ago

netniV, can you for the fix. Can you please take a look at issue #44 It is a next step in creating report that doesn't work in my opinion. Looking for your advice.