search

Cacti / plugin_reportit

ReportIt Plugin for Cacti
GNU General Public License v2.0
7 stars 9 forks source link

report graph viewing #50

Closed SergejLT closed 5 years ago

SergejLT commented 5 years ago

Hello, Using cacti v1.1.38, modern theme, new reportit plugin version.

right clicking on any data graph in the report I get blank new tab page (tried with firefox v62.0, and chrome v69.0.3497.100)

reportit_2

If I left click directly. It shows good in the same report page.

reportit_3

I see paths are diferent. Any thoughts?

netniV commented 5 years ago

Can you paste the relative parts of the URL to the cacti base for both before and after?

SergejLT commented 5 years ago

https://ip/cacti/graph.php?header=false&action=zoom&local_graph_id=76940&rra_id=0&graph_start=1537822800&graph_end=1537909199

https://ip/cacti/plugins/reportit/view.php?action=show_graph_overview&id=1&rrd=101084&cache=-1

netniV commented 5 years ago

And which works?

SergejLT commented 5 years ago

This one is working https://ip/cacti/plugins/reportit/view.php?action=show_graph_overview&id=1&rrd=101084&cache=-1

netniV commented 5 years ago

I am going to guess that it is purely the &header=false part that is failing for you

SergejLT commented 5 years ago

That did the trick. Deleted the &header=false and graph shown correctly.

Is it with browser or code problem?

netniV commented 5 years ago

Code. Unfortunately and not a lot we can do about it at this point in time as I'll have to test against multiple Cacti versions to see the best way to handle that.

SergejLT commented 5 years ago

ok, so editing in plugins/reportit/view.php line 897 from

header("Location: ../../graph.php?header=false&action=zoom&local_graph_id=$local_graph_id&rra_id=0&graph_start=$start&graph_end=$end");

to

header("Location: ../../graph.php?action=zoom&local_graph_id=$local_graph_id&rra_id=0&graph_start=$start&graph_end=$end");

got it working.

netniV commented 5 years ago

Yeah, but it may break in the normal process in other versions of Cacti

netniV commented 5 years ago

This has been fixed in 1.1.0, so look out for the release of that.