Report viewing doesn't honor separated "measurand"

Cacti / plugin_reportit

ReportIt Plugin for Cacti

GNU General Public License v2.0

7 stars 9 forks source link

Report viewing doesn't honor separated "measurand" #51

Closed ikorzha closed 5 years ago

ikorzha commented 5 years ago

netniV, I am not sure how far along are you in 1.10 release I figured that I better bring it to your attention prior to release. First screenshot is from ReportIt 0.8 version from Cacti .8.8x Please notice the last set of column called "overal" and how are they segregated from traffic in and traffic out since these statistics are unified per circuit

Second screenshot is from ReportIt 1.0.2 version from Cacti 1.1.38:

Notice there are NO overall column, and it doesn't group overall items together.

netniV commented 5 years ago

That might not make it into 1.1, purely because I have no idea how that works yet. As I progress through the plugin and an old 0.6.7 manual, I'm getting a better understanding but this advanced feature is something else ;-)

ikorzha commented 5 years ago

I will be happy to work with you on this item once you are ready to proceed.

ikorzha commented 5 years ago

netniV, I actually do not believe this is a difficult issue. Below is screenshot of one of the measurand. Notice that it has a checkmark on "Separate" All report needs to do is honor that field, group "separate" items together under overall column on right side of the report :) Good news I have a working old installation we can always compare and contrast..

netniV commented 5 years ago

all report needs to do .... the worst words to say to a programmer ;-)

That normally means a thousand linese of code, which then get ripped out as it's not what the user wanted at all ;-)

On a more serious note, it's a totalling column (the word separate is wrong imho). Subtotal, Total or some variation/relation thereof, would be a better description.

ikorzha commented 5 years ago

I laughed a lot on your comment "all reports needs to do"...

I would agree with you it is a "totaling" column, however I would defend a name that original developer described it as "overall" it does fits best Example: Overall circuit bandwidth 100Mbps or Overall Circuit availability 95% and so on...

netniV commented 5 years ago

Yes but the switch should not be separate... I don't like measurand either... in English that should be measure or measurement. But English is my like 16th language after C++, C#, Assembly, etc....

netniV commented 5 years ago

This should now be resolved.