search

Cacti / plugin_reportit

ReportIt Plugin for Cacti
GNU General Public License v2.0
7 stars 8 forks source link

ReportIT report view visual enhancement for readability #61

Closed ikorzha closed 5 years ago

ikorzha commented 5 years ago

netniV, first of all let me congratulate you on getting latest git 1.12 close to full functionality. There are a few items remaining that we are discussing in separate topics. Here I would like to point out some of the visual deficiencies of the report viewing tab, the goal is to make reportit plugin build quality on par with Cacti itself.

  1. traffic_in traffic_out and overall is currently left alignment. Please have them center alignment.
  2. Please introduce a separator | between traffic_in, traffic_out and overall.
  3. Please introduce a line grid for report items like it was in reportit 0.8 see screenshot below.
  4. I noticed a scaling problem, if reported item description is long enough it result in report portion being lost on right hand side, In 0.8 version this is addressed by wrapping the description field.

Screenshot from ReportIT 1.2: (browser zoom at 80%) image

Screenshot from ReportIT 0.8: image

Scaling problem screenshot 3: (browser zoom at 100%) image

netniV commented 5 years ago

So, the table is meant to be dynamic under cacti 1.x because it's designed to be flexible for screensizes. That means it decides when to drop columns off (I think the browser is the one that chooses I'm not really sure). Adding a left hand border to the subtitles is possible along with centering the text (I'd thought that too). Line grids, again, it's the standard of cacti so that all depends on the theme you are running.

ikorzha commented 5 years ago

netniV please do what ever you can, I would guess item 1, item 4 and most importantly item 4...if possible.

netniV commented 5 years ago

OK, done what I can. Think I've kinda addressed 3 out of 4 so 75% isn't bad ;-)

ikorzha commented 5 years ago

Visual fix is exceptional thank you very much. Happy with results.