Cacti / plugin_routerconfigs

Router Config Plugin for Cacti
GNU General Public License v2.0
10 stars 6 forks source link

Additional QA testing on routerconfigs sorting #126

Open jdcoats opened 1 year ago

jdcoats commented 1 year ago

Sorting of "Backup Time" "Last Change" or "Changed By" gives below I think this is related to spaces. because the sort by filename works properly without a space.

2023/01/30 16:29:58 - CMDPHP SQL Backtrace: (/plugins/routerconfigs/router-backups.php[45]:show_devices(), /plugins/routerconfigs/router-backups.php[143]:db_fetch_assoc_prepared(), /lib/database.php[697]:db_execute_prepared())
2023/01/30 16:29:58 - CMDPHP ERROR: A DB Row Failed!, Error: Unknown column 'backup' in 'order clause'

2023/01/30 16:39:01 - CMDPHP SQL Backtrace: (/plugins/routerconfigs/router-backups.php[45]:show_devices(), /plugins/routerconfigs/router-backups.php[143]:db_fetch_assoc_prepared(), /lib/database.php[697]:db_execute_prepared())
2023/01/30 16:39:01 - CMDPHP ERROR: A DB Row Failed!, Error: Unknown column 'change' in 'order clause'

2023/01/30 16:40:15 - CMDPHP SQL Backtrace: (/plugins/routerconfigs/router-backups.php[45]:show_devices(), /plugins/routerconfigs/router-backups.php[143]:db_fetch_assoc_prepared(), /lib/database.php[697]:db_execute_prepared())
2023/01/30 16:40:15 - CMDPHP ERROR: A DB Row Failed!, Error: Unknown column 'change_by' in 'order clause'

additionally, If you go to Devices and click Backups for any device you get no backup found for the filter. No errors thrown. image Clear the filter and type in search box it works

image

Additionally on Device tab, try to sort by hostname and this does not work. They are also not sorted Alphabetically or anything not sure what that logic is.

TheWitness commented 1 year ago

@jdcoats, the Backups page should be fixed. Not sure about the Devices though.

jdcoats commented 1 year ago

If you go to Devices and under the config column for any device you click backups you are taken to the backups page and none are displayed. image However if you clear the filter and the in the search field enter the device name the backups are displayed. image