search

Cacti / plugin_servcheck

GNU General Public License v2.0
1 stars 3 forks source link

Update arrays.php line#433 (how_often description) and 456 (downtrigger description) are not clear #12

Closed MSS970 closed 2 months ago

MSS970 commented 2 months ago

Update arrays.php line#433 (how_often description) and 456 (downtrigger description).

I have created a pull request and modified accordingly.

https://github.com/mohabuhtig/plugin_servcheck

Kindly review and let me know if good to go.

Regards, MSS

TheWitness commented 2 months ago

Yeah both pull requests are okay with me I need may need to work on the wording a little bit but yeah feel free especially that first one was pretty bad actually.

MSS970 commented 2 months ago

Hi, What is the easiest way to create a setting tab in the configuration/settings for servcheck?

Can you guide me please.

TheWitness commented 2 months ago

Go to your fork, and on the page, near the branch selector, there should be a "Contribute" button. Click it.

xmacan commented 2 months ago

@mohabuhtig Did you start working on "create a setting tab"? I have it on my TODO list too. I can do it in few days. let me know, please

MSS970 commented 2 months ago

Hi Peter,

I did not start, please proceed. Thank you very much in advance.

Regards, MSS

MSS970 commented 2 months ago

I have already submitted a pull request to update the wording in 2 lines:

Update arrays.php line#433 (how_often description) and 456 (downtrigger description) are not clear #12

Awaiting review.

MSS970 commented 2 months ago

and another pull request to fix the wrong operator:

Wrong operator = instead of == in file: servcheck_process.php, line# 493

Awaiting review.

xmacan commented 2 months ago

ok, thank you!

xmacan commented 2 months ago

@mohabuhtig settings added https://github.com/Cacti/plugin_servcheck/pull/14