Closed MSS970 closed 2 months ago
Yeah both pull requests are okay with me I need may need to work on the wording a little bit but yeah feel free especially that first one was pretty bad actually.
Hi, What is the easiest way to create a setting tab in the configuration/settings for servcheck?
Can you guide me please.
Go to your fork, and on the page, near the branch selector, there should be a "Contribute" button. Click it.
@mohabuhtig Did you start working on "create a setting tab"? I have it on my TODO list too. I can do it in few days. let me know, please
Hi Peter,
I did not start, please proceed. Thank you very much in advance.
Regards, MSS
I have already submitted a pull request to update the wording in 2 lines:
Update arrays.php line#433 (how_often description) and 456 (downtrigger description) are not clear #12
Awaiting review.
and another pull request to fix the wrong operator:
Wrong operator = instead of == in file: servcheck_process.php, line# 493
Awaiting review.
ok, thank you!
@mohabuhtig settings added https://github.com/Cacti/plugin_servcheck/pull/14
Update arrays.php line#433 (how_often description) and 456 (downtrigger description).
I have created a pull request and modified accordingly.
https://github.com/mohabuhtig/plugin_servcheck
Kindly review and let me know if good to go.
Regards, MSS