search

Cacti / plugin_thold

Thold Plugin for Cacti
GNU General Public License v2.0
61 stars 60 forks source link

[THOLD latest source] PHP error - plugin disabled #588

Closed anarkia1976 closed 1 year ago

anarkia1976 commented 1 year ago

Hi Guys,

i see some errors into logs after latest patches:

2023-07-24 11:55:19 - CMDPHP ERRORS DETECTED - DISABLING PLUGIN 'thold'
2023-07-24 11:55:19 - CMDPHP PHP ERROR Backtrace: (CactiShutdownHandler())
2023-07-24 11:55:19 - ERROR PHP ERROR in Plugin 'thold': Uncaught TypeError: Cannot access offset of type string on string in /var/www/html/cacti/plugins/thold/thold_functions.php:5593 Stack trace: #0 /var/www/html/cacti/plugins/thold/includes/polling.php(703): thold_mail() #1 /var/www/html/cacti/plugins/thold/poller_thold.php(140): thold_update_host_status() #2 /var/www/html/cacti/plugins/thold/poller_thold.php(96): perform_thold_processes() #3 {main} thrown in file: /var/www/html/cacti/plugins/thold/thold_functions.php on line: 5593

thanks a lot. Stefano.

TheWitness commented 1 year ago

Check for a more recent update. Anyway, doing a fairly substantial update. So, suggest a non-prod install. Till I get the last of the features honed in.

I'm looking for testers of the new notification queue, command execution via the queue, bcc use, and the two new baseline types.

anarkia1976 commented 1 year ago

Check for a more recent update. Anyway, doing a fairly substantial update. So, suggest a non-prod install. Till I get the last of the features honed in.

I'm looking for testers of the new notification queue, command execution via the queue, bcc use, and the two new baseline types.

you are right, i have made a rollaback latest patches. we wait the new release. thanks a lot as always.

TheWitness commented 1 year ago

It's going to be a pretty substantial update. We could use more testers. I had writers block on this plugin till over the weekend. There were so many ticket. After this release, we already have plans for another more significant rework. However, that will not happen before 1.3.

TheWitness commented 1 year ago

Okay, I experienced this over-night too. Just fixing.

anarkia1976 commented 1 year ago

good, thanks a lot for fast fix. it will be fantastic to have a stable branch 1.2.x also for THOLD and a new branch with latest experimental commits. what do you think?

TheWitness commented 1 year ago

I need to make a minor schema change. Don't update till you see that. Also waiting on another RFE from @bmfmancini to cover notification storm suppression and another feature around severity, the later of which may be post release.