search

Cacti / plugin_thold

Thold Plugin for Cacti
GNU General Public License v2.0
61 stars 60 forks source link

Register Process - incorrect parameters #608

Closed xmacan closed 11 months ago

xmacan commented 11 months ago

Few CLI scripts run register_process_start('rfloat', $type, $thread_id, 86400)) But function is declared: function register_process($tasktype, $taskname, $taskid, $pid, $timeout) {

It works, but result is: Select * from processes; +--------+------+----------+----------+--------+---------+---------------------+---------------------+ | id | pid | tasktype | taskname | taskid | timeout | started | last_update | +--------+------+----------+----------+--------+---------+---------------------+---------------------+ | 309318 | 7140 | pushout | rmaster | 0 | 86400 | 2023-08-16 15:25:39 | 2023-08-16 15:25:39 | | 309319 | 7143 | pushout | child | 1 | 86400 | 2023-08-16 15:25:39 | 2023-08-16 15:25:39 | | 309320 | 7145 | pushout | child | 2 | 86400 | 2023-08-16 15:25:39 | 2023-08-16 15:25:39 | | 309322 | 7148 | pushout | child | 3 | 86400 | 2023-08-16 15:25:39 | 2023-08-16 15:25:39 | | 309323 | 7150 | pushout | child | 4 | 86400 | 2023-08-16 15:25:39 | 2023-08-16 15:25:39 | | 309321 | 7152 | pushout | child | 5 | 86400 | 2023-08-16 15:25:39 | 2023-08-16 15:25:39 | +--------+------+----------+----------+--------+---------+---------------------+---------------------+

It seems that thold has the same problem: +----------+----------+ | tasktype | taskname | +----------+----------+ | thold | master | +----------+----------+

TheWitness commented 11 months ago

Transferred this to Thold and resolved. There was still one issue in Cacti's lib/api_tree.php which I also corrected.

TheWitness commented 11 months ago

Resolved here: https://github.com/Cacti/plugin_thold/commit/f80527becac945cc5dc319c7472ebd0efc9821bb