search

Cacti / plugin_thold

Thold Plugin for Cacti
GNU General Public License v2.0
60 stars 60 forks source link

Fix #621 notifications #661

Closed unka65 closed 2 months ago

unka65 commented 4 months ago

This fixes the unexpected and missing notifications. This does not address determining if a threshold has been reached.

Changed maintenance mode so no unexpected notify (to normal but no warning/alert) after off maintenance.

Eliminated missing and unexpected high/low notifications by not clearing counters at warning and alert level until notified. If at warning level, included alert counts not notified.

Moved Alert to Warning section so that can occur. This made the changes seem more significant than actual.

Fixed error (thold_id not valid) for baseline type in get_email_subject: changed thold_id to thold_hi

TheWitness commented 4 months ago

I'll be reviewing this over the weekend.

TheWitness commented 3 months ago

Getting back to this now. I'm going to merge commit these one at a time as I rationalize the changes. Hope that's okay with you.

TheWitness commented 3 months ago

@unka65 please check my last comment in case you missed the notification.

TheWitness commented 3 months ago

@unka65, update to the latest develop and rework your patches after you read through my latest comments. The re-update your poll request.

I will take a second look then.