Undefined array key "external_id

[jdcoats]

After upgrading thold today

2024/09/18 19:06:37 - CMDPHP PHP ERROR WARNING Backtrace: (/plugins/thold/poller_thold.php[99]:perform_thold_processes(), /plugins/thold/poller_thold.php[154]:thold_check_all_thresholds(), /plugins/thold/includes/polling.php[332]:thold_check_threshold(), /plugins/thold/thold_functions.php[2287]:get_thold_alert_text(), /plugins/thold/thold_functions.php[4117]:thold_replace_threshold_tags(), /plugins/thold/thold_functions.php[4060]:CactiErrorHandler())
2024/09/18 19:06:37 - ERROR PHP WARNING in Plugin 'thold': Undefined array key "external_id" in file: /var/www/localhost/htdocs/cacti/plugins/thold/thold_functions.php on line: 4060

[TheWitness]

MariaDB [cacti]> desc thold_data;
+-----------------------------+------------------+------+-----+---------------------+----------------+
| Field                       | Type             | Null | Key | Default             | Extra          |
+-----------------------------+------------------+------+-----+---------------------+----------------+
| id                          | int(11)          | NO   | PRI | NULL                | auto_increment |
| thread_id                   | int(11) unsigned | NO   |     | 0                   |                |
| name                        | varchar(150)     | YES  |     | NULL                |                |
| name_cache                  | varchar(150)     | YES  |     | NULL                |                |
| local_data_id               | int(11)          | NO   | MUL | 0                   |                |
| data_template_rrd_id        | int(11) unsigned | NO   | MUL | 0                   |                |
| local_graph_id              | int(11)          | NO   | MUL | 0                   |                |
| graph_template_id           | int(11)          | NO   | MUL | 0                   |                |
| data_template_id            | int(11)          | NO   | MUL | 0                   |                |
| data_template_hash          | varchar(32)      | NO   |     |                     |                |
| data_source_name            | varchar(100)     | NO   |     |                     |                |
| thold_hi                    | varchar(100)     | YES  |     | NULL                |                |
| thold_low                   | varchar(100)     | YES  |     | NULL                |                |
| thold_fail_trigger          | int(11) unsigned | YES  |     | NULL                |                |
| thold_fail_count            | int(11)          | NO   |     | 0                   |                |
| time_hi                     | varchar(100)     | YES  |     | NULL                |                |
| time_low                    | varchar(100)     | YES  |     | NULL                |                |
| time_fail_trigger           | int(12)          | NO   |     | 1                   |                |
| time_fail_length            | int(12)          | NO   |     | 1                   |                |
| thold_warning_hi            | varchar(100)     | YES  |     | NULL                |                |
| thold_warning_low           | varchar(100)     | YES  |     | NULL                |                |
| thold_warning_fail_trigger  | int(11) unsigned | YES  |     | NULL                |                |
| thold_warning_fail_count    | int(11)          | NO   |     | 0                   |                |
| time_warning_hi             | varchar(100)     | YES  |     | NULL                |                |
| time_warning_low            | varchar(100)     | YES  |     | NULL                |                |
| time_warning_fail_trigger   | int(12)          | NO   |     | 1                   |                |
| time_warning_fail_length    | int(12)          | NO   |     | 1                   |                |
| thold_alert                 | int(1)           | NO   |     | 0                   |                |
| prev_thold_alert            | int(1)           | NO   |     | 0                   |                |
| thold_enabled               | enum('on','off') | NO   | MUL | on                  |                |
| thold_per_enabled           | char(3)          | NO   |     | on                  |                |
| thold_type                  | int(3)           | NO   |     | 0                   |                |
| bl_ref_time_range           | int(11) unsigned | YES  |     | NULL                |                |
| bl_type                     | int(3)           | NO   |     | 0                   |                |
| bl_pct_down                 | varchar(100)     | YES  |     | NULL                |                |
| bl_pct_up                   | varchar(100)     | YES  |     | NULL                |                |
| bl_fail_trigger             | int(11) unsigned | YES  |     | NULL                |                |
| bl_fail_count               | int(11) unsigned | YES  |     | NULL                |                |
| bl_alert                    | int(2)           | NO   |     | 0                   |                |
| bl_cf                       | varchar(4)       | NO   |     | AVG                 |                |
| bl_reference_min            | double           | YES  |     | 0                   |                |
| bl_reference_max            | double           | YES  |     | 0                   |                |
| bl_reference_avg            | double           | YES  |     | 0                   |                |
| bl_reference_last           | double           | YES  |     | 0                   |                |
| bl_thold_valid              | int(11) unsigned | NO   |     | 0                   |                |
| lastread                    | varchar(100)     | YES  |     | NULL                |                |
| lasttime                    | timestamp        | NO   |     | 0000-00-00 00:00:00 |                |
| lastchanged                 | timestamp        | NO   |     | 0000-00-00 00:00:00 |                |
| oldvalue                    | varchar(100)     | YES  |     | NULL                |                |
| repeat_alert                | int(11) unsigned | YES  |     | NULL                |                |
| notify_extra                | varchar(512)     | YES  |     | NULL                |                |
| notify_warning_extra        | varchar(512)     | YES  |     | NULL                |                |
| notify_warning              | int(11) unsigned | YES  |     | NULL                |                |
| notify_alert                | int(11) unsigned | YES  |     | NULL                |                |
| snmp_event_category         | varchar(255)     | YES  |     | NULL                |                |
| snmp_event_description      | varchar(1000)    | YES  |     | NULL                |                |
| snmp_event_severity         | tinyint(1)       | NO   |     | 3                   |                |
| snmp_event_warning_severity | tinyint(1)       | NO   |     | 2                   |                |
| host_id                     | int(11) unsigned | YES  | MUL | NULL                |                |
| syslog_priority             | int(2)           | NO   |     | 3                   |                |
| syslog_facility             | int(2)           | YES  |     | NULL                |                |
| syslog_enabled              | char(3)          | NO   |     |                     |                |
| data_type                   | int(12)          | NO   |     | 0                   |                |
| show_units                  | char(3)          | NO   |     |                     |                |
| units_suffix                | varchar(10)      | NO   |     |                     |                |
| decimals                    | int(11)          | NO   |     | -1                  |                |
| cdef                        | int(11)          | NO   |     | 0                   |                |
| percent_ds                  | varchar(64)      | NO   |     |                     |                |
| expression                  | varchar(512)     | NO   |     |                     |                |
| upper_ds                    | varchar(64)      | NO   |     |                     |                |
| thold_template_id           | int(11)          | NO   | MUL | 0                   |                |
| template_enabled            | char(3)          | NO   | MUL |                     |                |
| tcheck                      | int(1)           | NO   | MUL | 0                   |                |
| exempt                      | char(3)          | NO   |     |                     |                |
| acknowledgment              | char(3)          | NO   |     |                     |                |
| thold_hrule_alert           | int(11) unsigned | YES  |     | NULL                |                |
| thold_hrule_warning         | int(11) unsigned | YES  |     | NULL                |                |
| skipscale                   | char(3)          | NO   |     |                     |                |
| restored_alert              | char(3)          | NO   |     |                     |                |
| reset_ack                   | char(3)          | NO   |     |                     |                |
| persist_ack                 | char(3)          | NO   |     |                     |                |
| email_subject               | varchar(128)     | NO   |     |                     |                |
| email_subject_warn          | varchar(128)     | NO   |     |                     |                |
| email_subject_restoral      | varchar(128)     | NO   |     |                     |                |
| email_body                  | varchar(1024)    | NO   |     |                     |                |
| email_body_warn             | varchar(1024)    | NO   |     |                     |                |
| email_body_restoral         | varchar(1024)    | NO   |     |                     |                |
| trigger_cmd_high            | varchar(512)     | NO   |     |                     |                |
| trigger_cmd_low             | varchar(512)     | NO   |     |                     |                |
| trigger_cmd_norm            | varchar(512)     | NO   |     |                     |                |
| notes                       | varchar(1024)    | YES  |     |                     |                |
| external_id                 | varchar(20)      | YES  |     |                     |                |
| format_file                 | varchar(255)     | NO   |     |                     |                |
| graph_timespan              | int(11) unsigned | NO   |     | 7                   |                |
+-----------------------------+------------------+------+-----+---------------------+----------------+
94 rows in set (0.001 sec)

[jdcoats]

MariaDB [cacti]> desc thold_data;
+-----------------------------+------------------+------+-----+---------------------+----------------+
| Field                       | Type             | Null | Key | Default             | Extra          |
+-----------------------------+------------------+------+-----+---------------------+----------------+
| id                          | int(11)          | NO   | PRI | NULL                | auto_increment |
| thread_id                   | int(10) unsigned | NO   |     | 0                   |                |
| name                        | varchar(150)     | YES  |     | NULL                |                |
| name_cache                  | varchar(100)     | YES  |     | NULL                |                |
| local_data_id               | int(11)          | NO   | MUL | 0                   |                |
| data_template_rrd_id        | int(11)          | NO   | MUL | 0                   |                |
| local_graph_id              | int(11)          | NO   | MUL | 0                   |                |
| graph_template_id           | int(11)          | NO   | MUL | 0                   |                |
| data_template_hash          | varchar(32)      | YES  |     |                     |                |
| data_template_id            | int(11)          | NO   | MUL | 0                   |                |
| data_source_name            | varchar(100)     | NO   |     |                     |                |
| thold_hi                    | varchar(100)     | YES  |     | NULL                |                |
| thold_low                   | varchar(100)     | YES  |     | NULL                |                |
| thold_fail_trigger          | int(10) unsigned | YES  |     | NULL                |                |
| thold_fail_count            | int(11)          | NO   |     | 0                   |                |
| time_hi                     | varchar(100)     | YES  |     | NULL                |                |
| time_low                    | varchar(100)     | YES  |     | NULL                |                |
| time_fail_trigger           | int(12)          | NO   |     | 1                   |                |
| time_fail_length            | int(12)          | NO   |     | 1                   |                |
| thold_warning_hi            | varchar(100)     | YES  |     | NULL                |                |
| thold_warning_low           | varchar(100)     | YES  |     | NULL                |                |
| thold_warning_fail_trigger  | int(10) unsigned | YES  |     | NULL                |                |
| thold_warning_fail_count    | int(11)          | NO   |     | 0                   |                |
| time_warning_hi             | varchar(100)     | YES  |     | NULL                |                |
| time_warning_low            | varchar(100)     | YES  |     | NULL                |                |
| time_warning_fail_trigger   | int(12)          | NO   |     | 1                   |                |
| time_warning_fail_length    | int(12)          | NO   |     | 1                   |                |
| thold_alert                 | int(1)           | NO   |     | 0                   |                |
| prev_thold_alert            | int(1)           | NO   |     | 0                   |                |
| thold_enabled               | enum('on','off') | NO   | MUL | on                  |                |
| thold_per_enabled           | char(3)          | NO   |     | on                  |                |
| thold_type                  | int(3)           | NO   |     | 0                   |                |
| bl_ref_time_range           | int(10) unsigned | YES  |     | NULL                |                |
| bl_type                     | int(3)           | NO   |     | 0                   |                |
| bl_pct_down                 | varchar(100)     | YES  |     | NULL                |                |
| bl_pct_up                   | varchar(100)     | YES  |     | NULL                |                |
| bl_fail_trigger             | int(10) unsigned | YES  |     | NULL                |                |
| bl_fail_count               | int(11) unsigned | YES  |     | NULL                |                |
| bl_alert                    | int(2)           | NO   |     | 0                   |                |
| bl_cf                       | varchar(4)       | NO   |     | AVG                 |                |
| bl_reference_min            | double           | YES  |     | 0                   |                |
| bl_reference_max            | double           | YES  |     | 0                   |                |
| bl_reference_avg            | double           | NO   |     | 0                   |                |
| bl_reference_last           | double           | NO   |     | 0                   |                |
| bl_thold_valid              | int(10) unsigned | NO   |     | 0                   |                |
| lastread                    | varchar(100)     | YES  |     | NULL                |                |
| lasttime                    | timestamp        | NO   |     | 0000-00-00 00:00:00 |                |
| lastchanged                 | timestamp        | NO   |     | 0000-00-00 00:00:00 |                |
| oldvalue                    | varchar(100)     | YES  |     | NULL                |                |
| repeat_alert                | int(10) unsigned | YES  |     | NULL                |                |
| notify_extra                | varchar(512)     | YES  |     |                     |                |
| notify_warning_extra        | varchar(512)     | YES  |     | NULL                |                |
| notify_warning              | int(10) unsigned | YES  |     | NULL                |                |
| notify_alert                | int(10) unsigned | YES  |     | NULL                |                |
| snmp_event_category         | varchar(255)     | YES  |     | NULL                |                |
| snmp_event_description      | varchar(1000)    | YES  |     | NULL                |                |
| snmp_event_severity         | tinyint(1)       | NO   |     | 3                   |                |
| snmp_event_warning_severity | tinyint(1)       | NO   |     | 2                   |                |
| host_id                     | int(10)          | YES  | MUL | NULL                |                |
| syslog_priority             | int(2)           | NO   |     | 3                   |                |
| syslog_facility             | int(2)           | YES  |     | NULL                |                |
| syslog_enabled              | char(3)          | NO   |     |                     |                |
| data_type                   | int(12)          | NO   |     | 0                   |                |
| show_units                  | char(3)          | NO   |     |                     |                |
| units_suffix                | varchar(10)      | NO   |     |                     |                |
| decimals                    | int(11)          | NO   |     | -1                  |                |
| cdef                        | int(11)          | NO   |     | 0                   |                |
| percent_ds                  | varchar(64)      | NO   |     |                     |                |
| expression                  | varchar(512)     | NO   |     |                     |                |
| upper_ds                    | varchar(64)      | NO   |     |                     |                |
| thold_template_id           | int(11)          | NO   | MUL | 0                   |                |
| template_enabled            | char(3)          | NO   | MUL |                     |                |
| tcheck                      | int(1)           | NO   | MUL | 0                   |                |
| exempt                      | char(3)          | NO   |     |                     |                |
| acknowledgment              | char(3)          | NO   |     |                     |                |
| thold_hrule_alert           | int(11) unsigned | YES  |     | NULL                |                |
| thold_hrule_warning         | int(11) unsigned | YES  |     | NULL                |                |
| skipscale                   | char(3)          | YES  |     |                     |                |
| restored_alert              | char(3)          | NO   |     |                     |                |
| reset_ack                   | char(3)          | NO   |     |                     |                |
| persist_ack                 | char(3)          | NO   |     |                     |                |
| email_subject               | varchar(128)     | NO   |     |                     |                |
| email_subject_warn          | varchar(128)     | NO   |     |                     |                |
| email_subject_restoral      | varchar(128)     | NO   |     |                     |                |
| email_body                  | varchar(1024)    | YES  |     |                     |                |
| email_body_warn             | varchar(1024)    | NO   |     |                     |                |
| email_body_restoral         | varchar(1024)    | NO   |     |                     |                |
| trigger_cmd_high            | varchar(512)     | NO   |     |                     |                |
| trigger_cmd_low             | varchar(512)     | NO   |     |                     |                |
| trigger_cmd_norm            | varchar(512)     | NO   |     |                     |                |
| notes                       | varchar(1024)    | YES  |     |                     |                |
| format_file                 | varchar(255)     | NO   |     |                     |                |
| graph_timespan              | int(11) unsigned | NO   |     | 7                   |                |
+-----------------------------+------------------+------+-----+---------------------+----------------+
93 rows in set (0.001 sec)

[jdcoats]

i had to disable + re-enable plugin to get external_id

[bmfmancini]

When you did the uograde did you just copy the files over?

Enable / disable would have run the setup To add any additional columns in the new version

Always a good idea to disable Then copy files over then Enable

On Thu, Sep 19, 2024, 07:47 jdcoats @.***> wrote:

i had to disable + re-enable plugin to get external_id

— Reply to this email directly, view it on GitHub https://github.com/Cacti/plugin_thold/issues/695#issuecomment-2360767133, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADGEXTDRDDBHSYQN3JSWJ3LZXK2V7AVCNFSM6AAAAABOOWJVAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRQG43DOMJTGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[jdcoats]

yes i always just copy files over and go to settings and hit save. That's usually plenty.

[xmacan]

I have revised it. External_id is in setup_database and update too. @jdcoats - maybe you updated from unrelease previous 1.8 to 1.8 and column wasn't created