search

CactusDev / CactusBot

An open source, community-written service-agnostic chat bot
MIT License
30 stars 6 forks source link

Should we move Beam's Constellation interactions into Sepal? #211

Closed Innectic closed 7 years ago

Innectic commented 7 years ago

Moving these interactions into sepal would make the future alerts system much easier to actually handle, and would make event caching ( #185 ) not terribly hard to implement at all.

2Cubed commented 7 years ago

I think we should keep all connections to services in the main bot. To me, it seems like much better encapsulation.

Innectic commented 7 years ago

@2Cubed How do we handle caching, and stream alerts then? The bot is not a suitable place for any of that

2Cubed commented 7 years ago

@Innectic That's an excellent question.

I think for caching, we might just want to make an API request which does "some Redis stuff", and then make a quick request to check if the user is in the cache before sending the notification. (We could also add a way to clear the cache from the dashboard, for example.)

Not sure what you mean about "stream alerts".

Innectic commented 7 years ago

@2Cubed: Stream alerts = on stream alerts (X PERSON JUST FOLLOWED OMGLOLYESTHANKSFORTHEFOLLOW)

2Cubed commented 7 years ago

Ah, I see! Can't that just stay in the bot, like it is now? (Not talking about caching, BTW.) :slightly_smiling_face:

Innectic commented 7 years ago

I'm talking about on stream, not in chat

2Cubed commented 7 years ago

@Innectic Oh, I see. Can't the bot just send "ohey, a follow happened" packets to Sepal, and then Sepal will distribute those to clients? :)

Innectic commented 7 years ago

@2Cubed The original intention for sepal was that the bot never interacts with it. The only time the bot was ever supposed to send something to sepal was authentication

2Cubed commented 7 years ago

@Innectic Hmm... why? I don't see any reason why we shouldn't allow that... :thinking: