CactusDev / CactusBot

An open source, community-written service-agnostic chat bot
MIT License
30 stars 6 forks source link

Switch handlers to asynchronous generators #253

Closed willow-bohlen closed 7 years ago

willow-bohlen commented 7 years ago

I was just looking around in the code, and noticed this at line 88 of cactusbot/handler.py:

# TODO: In Python 3.6, with asynchronous generators: # yield packet

Well we're in 3.6 now, so go for it.

Innectic commented 7 years ago

This can't be done yet. We can't assume that everyone is always on 3.6, because it's too new. This is being pushed to 0.5.

willow-bohlen commented 7 years ago

fiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiinnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnneeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee

Innectic commented 7 years ago

Merged into #254