search

CactusDev / CactusBot

An open source, community-written service-agnostic chat bot
MIT License
30 stars 6 forks source link

Bot ignores rate limits #308

Closed 2Cubed closed 6 years ago

2Cubed commented 7 years ago

The bot ignores rate limits, trying to send messages whenever they are received. This especially impacts responses that are split over multiple chat messages.

Innectic commented 7 years ago

Important thing: Each service handler needs to implement this some how. Different services have different rate limits.

2Cubed commented 7 years ago

We should probably have a generalized ratelimit method somewhere in the WebSocket class, which can either be used or ignored by the individual services.

Innectic commented 7 years ago

It shouldn't be able to be ignored. It should be required.

Alkali-Metal commented 7 years ago

Maybe make it so that if a service rate limit isn't supplied by the handler (Or whatever would handle it) it then falls back to the default one and can't be bypassed?

2Cubed commented 6 years ago

Issue moved to CactusDev/Aerophyl #9 via ZenHub