Closed ghost closed 8 years ago
Taking a look now :)
@MysticalMage There's a few things I do like in here, but, we plan to put the caching into our api. However, I do like the changes to the config, and to the docs. I think we could totally use those parts! Also, congrats on being the first external contributor!
CC // @2Cubed @RPiAwesomeness
EDIT: We're doing some internal discussion, and it seems that we might merge this :D
@Innectic AHEM (jk)
Neat stuff mage! Glad to see you're doing stuff with CB! (for everyone else, mage is an IRL friend of mine, and I told him about CB :> )
Also, I'd like to thank you for actually testing your code!
@QuirkySquid If your "ahem" is about your pull, I'm putting it into 0.4 :D
@Innectic BUT I DEED IT FUURURRRSSSSTTTTTTT (jk jk jk jk)
also, if commands are gonna be really different, I'd be happy to make it work in 0.4 myself.
@QuirkySquid Feel free to give it a shot. The command system should be stable enough on the feature/handlers
branch that you can start and it can be in the first release of 0.4
@Innectic GNARLY. runs off to 0.4
Basically did a rewrite, code has changed substantially
Didn't add @classmethod
because now I'm creating an instance of the class when I need it (I think that is how it works)
Psst, @MysticalMage, would you have happened to make any progress on the things that @2Cubed said?
I've written it but haven't had a chance to test it yet.
Ah, ok
Looks really good to me! :+1: from me.
I think it's ready !
@Innectic GitMate says that "this commit needs review"... o.O
@2Cubed Me saying the word "ready" should have fixed that :thinking:
@2Cubed Is that a +1 from you?
@Innectic Yeah, I'm fine with it... just needs to be manually merged, apparently.
@2Cubed @MysticalMage I'm merging now :)
Merged! Thank you so much, @MysticalMage for all your work!
Agreed! Psst, @Innectic - could you add @MysticalMage to CONTRIBUTORS.md
? :smile:
@2Cubed On it!
It works™
I tested add the code and it works 100% of the times I tested it
Config Option
The default state is off, but when set to true, reduces spam
Updated setup
I fixed some of the problems in Setup.md and updated it to work with new code
PEP 8 Compliant
All new code meets the standards set out by PEP 8
More to come
I plan on adding options to cache hosts for an amount of time set in config to reduce follow spam.