CactusDev / CactusBot

An open source, community-written service-agnostic chat bot
MIT License
30 stars 5 forks source link

Added Follower Caching #56

Closed ghost closed 8 years ago

ghost commented 8 years ago

It works™

I tested add the code and it works 100% of the times I tested it

Config Option

The default state is off, but when set to true, reduces spam

Updated setup

I fixed some of the problems in Setup.md and updated it to work with new code

PEP 8 Compliant

All new code meets the standards set out by PEP 8

More to come

I plan on adding options to cache hosts for an amount of time set in config to reduce follow spam.

Innectic commented 8 years ago

Taking a look now :)

Innectic commented 8 years ago

@MysticalMage There's a few things I do like in here, but, we plan to put the caching into our api. However, I do like the changes to the config, and to the docs. I think we could totally use those parts! Also, congrats on being the first external contributor!

CC // @2Cubed @RPiAwesomeness

EDIT: We're doing some internal discussion, and it seems that we might merge this :D

willow-bohlen commented 8 years ago

@Innectic AHEM (jk)

Neat stuff mage! Glad to see you're doing stuff with CB! (for everyone else, mage is an IRL friend of mine, and I told him about CB :> )

Innectic commented 8 years ago

Also, I'd like to thank you for actually testing your code!

Innectic commented 8 years ago

@QuirkySquid If your "ahem" is about your pull, I'm putting it into 0.4 :D

willow-bohlen commented 8 years ago

@Innectic BUT I DEED IT FUURURRRSSSSTTTTTTT (jk jk jk jk)

also, if commands are gonna be really different, I'd be happy to make it work in 0.4 myself.

Innectic commented 8 years ago

@QuirkySquid Feel free to give it a shot. The command system should be stable enough on the feature/handlers branch that you can start and it can be in the first release of 0.4

willow-bohlen commented 8 years ago

@Innectic GNARLY. runs off to 0.4

ghost commented 8 years ago

Basically did a rewrite, code has changed substantially

Didn't add @classmethod because now I'm creating an instance of the class when I need it (I think that is how it works)

Innectic commented 8 years ago

Psst, @MysticalMage, would you have happened to make any progress on the things that @2Cubed said?

ghost commented 8 years ago

I've written it but haven't had a chance to test it yet.

Innectic commented 8 years ago

Ah, ok

Innectic commented 8 years ago

Looks really good to me! :+1: from me.

Innectic commented 8 years ago

I think it's ready !

2Cubed commented 8 years ago

@Innectic GitMate says that "this commit needs review"... o.O

Innectic commented 8 years ago

@2Cubed Me saying the word "ready" should have fixed that :thinking:

Innectic commented 8 years ago

@2Cubed Is that a +1 from you?

2Cubed commented 8 years ago

@Innectic Yeah, I'm fine with it... just needs to be manually merged, apparently.

Innectic commented 8 years ago

@2Cubed @MysticalMage I'm merging now :)

Innectic commented 8 years ago

Merged! Thank you so much, @MysticalMage for all your work!

2Cubed commented 8 years ago

Agreed! Psst, @Innectic - could you add @MysticalMage to CONTRIBUTORS.md? :smile:

Innectic commented 8 years ago

@2Cubed On it!