search

CadQuery / CQ-editor

CadQuery GUI editor based on PyQT
Apache License 2.0
723 stars 111 forks source link

Fix constructor missing library issue when env is not activated #417

Closed lorenzncode closed 7 months ago

lorenzncode commented 7 months ago
lorenzncode commented 7 months ago

Resolves #415.

The same could be applied for Linux/MacOS (if needed or for consistency). On Linux I didn't find conda run necessary (to launch cq-editor from run.sh without activating the conda env) because RPATH is set: Library rpath: [$ORIGIN/../lib]. I see #403 is open for MacOS.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (181adb9) 88.60% compared to head (c2f6d24) 88.60%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #417 +/- ## ======================================= Coverage 88.60% 88.60% ======================================= Files 19 19 Lines 1553 1553 Branches 189 189 ======================================= Hits 1376 1376 Misses 143 143 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adam-urbanczyk commented 7 months ago

LGTM, thanks @lorenzncode !