search

CadQuery / CQ-editor

CadQuery GUI editor based on PyQT
Apache License 2.0
723 stars 111 forks source link

Fix icon in taskbar on Windows #421

Closed roel-v closed 5 months ago

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4ef178a) 88.60% compared to head (b286b4e) 88.68%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #421 +/- ## ========================================== + Coverage 88.60% 88.68% +0.08% ========================================== Files 19 19 Lines 1553 1564 +11 Branches 189 190 +1 ========================================== + Hits 1376 1387 +11 Misses 143 143 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adam-urbanczyk commented 6 months ago

I don't see any issues with the taskbar icon.

roel-v commented 6 months ago

This is what it looks like without my fix (Windows 11):

image

This is what it looks like with the fix:

image

adam-urbanczyk commented 6 months ago

I cannot reproduce.

roel-v commented 6 months ago

Yeah I'm not sure what to tell you, the screenshots show that it's clearly an issue on my machine, and that my proposed fix actually fixes it. See e.g. https://stackoverflow.com/questions/1551605/how-to-set-applications-taskbar-icon-in-windows-7 , I'm not making this up. Do you maybe have something like 'never group taskbar icons' enabled on your machine.

adam-urbanczyk commented 5 months ago

Thanks @roel-v !