search

CadQuery / CQ-editor

CadQuery GUI editor based on PyQT
Apache License 2.0
723 stars 111 forks source link

Win32 strip console sequences in log #422

Closed roel-v closed 6 months ago

roel-v commented 6 months ago

The console view has colored output. The escape sequences that make this happen are also included in the log view, which makes it hard to read. This patch removes all escape sequences from logged string.

I think this is an issue only on Windows, hence the platform guard. If this happens on other platforms, this guard should of course be deleted.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4ef178a) 88.60% compared to head (e019036) 88.65%.

Files Patch % Lines
cq_editor/widgets/log.py 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #422 +/- ## ========================================== + Coverage 88.60% 88.65% +0.05% ========================================== Files 19 19 Lines 1553 1560 +7 Branches 189 189 ========================================== + Hits 1376 1383 +7 Misses 143 143 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adam-urbanczyk commented 6 months ago

Looks useful, I think the issue will be visible on all platforms. Could you remove the if and get rid of the unrelated commit?

roel-v commented 6 months ago

I've reverted the one commit that had the taskbar icon changes, and pushed another that removed the platform check, both to my branch. Is this enough to update the pull request or do I have to do something else?

adam-urbanczyk commented 6 months ago

LGTM, thanks @roel-v