CadQuery / cadquery-plugins

A collection of community contributed plugins that extend the functionality of CadQuery
Apache License 2.0
38 stars 15 forks source link

Lint Check Does Not Run Properly On Forks #14

Closed jmwright closed 3 years ago

jmwright commented 3 years ago

When run against a fork, the lint check will show a failure even when the check passes. The problem is not straight forward for the original Action dev to fix though.

References:

The PSF created a black Action, but it doesn't seem to really be documented and I'm thinking it would suffer from the same bug of not working on forks since it's due to lacking functionality on GitHub's side.

I could also just try running black manually in our lint check Action.

marcus7070 commented 3 years ago

Closed in #22 (unless we want some of the fancy annotations or other features that #22 doesn't do).

Here is correct clean run and dirty run.

jmwright commented 3 years ago

Thanks @marcus7070