search

CadQuery / cadquery-plugins

A collection of community contributed plugins that extend the functionality of CadQuery
Apache License 2.0
38 stars 15 forks source link

Initial commit of extrusions plugin for code review #25

Closed martinbudden closed 2 years ago

martinbudden commented 3 years ago

This is an incomplete initial submission for code review.

It addresses issue #3 [Plugin Request] Aluminum Profile Generator

martinbudden commented 3 years ago

Changed to use pkg_resources rather than importlib.resources. It seems importlib.resources.files() is new in python 3.9.

jmwright commented 3 years ago

@martinbudden I assume that by "incomplete initial submission" you mean that it doesn't include an exhaustive list of profiles that it can generate. This is ready for review as-is, correct?

martinbudden commented 3 years ago

@jmwright , sorry, should have been more clear. Yes this is ready for review. When I said incomplete, I was mainly referring to the documentation - that's still not fully complete, but it's almost there. As for the types of extrusions, I don't plan to add any fore for this submission, though I will probably add some more in future.

I'm particularly keen for you to review the style, and see if it fits in with cadquery style. I'm also not really a python programmer, so if there are any python-related issues it would be good if those were pointed out.

jmwright commented 2 years ago

Thanks @martinbudden Sorry it took so long for me to review this. A couple of PRs got missed in this repo.

jmwright commented 2 years ago

Sorry, I got overzealous on merging this one. I see there is still outstanding discussion items.I have reverted the merge.