search

CadQuery / cadquery-plugins

A collection of community contributed plugins that extend the functionality of CadQuery
Apache License 2.0
38 stars 15 forks source link

Add other "each" options #28

Closed geiseri closed 2 years ago

geiseri commented 2 years ago

The underlying Workplane.each(...) has options to combine and clean the resulting operation on the surface. In my case doing a 'cut' is much easier to do during the callback instead of trying to merge it together at the end.

jmwright commented 2 years ago

@geiseri This pin was added to the CQ core to fix the error that I'm seeing with lint. It will probably be easiest if you add it, but I can also add it to main and you can merge that into your branch if you want. It's up to you.

@fedorkotov You implemented this plugin originally. Do you have any thoughts on the changes?

geiseri commented 2 years ago

If you could add it that would keep the patch smaller. your call though.

jmwright commented 2 years ago

If you could add it that would keep the patch smaller.

@geiseri Done in #29 . Your lint step should be free of that bug once you have those changes on your branch.

jmwright commented 2 years ago

@geiseri The lint check is failing due to a formatting error now.

geiseri commented 2 years ago

yeah, sorry just noticed. should be good now

jmwright commented 2 years ago

@geiseri Thanks for the contribution!