Fix VTK assembly render apply gp_Intrinsic_ZXY rotation

CadQuery / cadquery

A python parametric CAD scripting framework based on OCCT

https://cadquery.readthedocs.io

Other

2.93k stars 276 forks source link

Fix VTK assembly render apply gp_Intrinsic_ZXY rotation #1540

Closed lorenzncode closed 3 months ago

lorenzncode commented 3 months ago

Resolves #1538

See also SetOrientation https://vtk.org/doc/nightly/html/classvtkProp3D.html

Sets the orientation of the Prop3D.

Orientation is specified as X,Y and Z rotations in that order, but they are performed as RotateZ, RotateX, and finally RotateY.

Location might instead be enhanced to provide optional parameter to set gp_EulerSequence say in toTuple. Currently hardcoding in the VTK function.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.48%. Comparing base (153ed3f) to head (b1f99e1).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1540 +/- ## ======================================= Coverage 94.48% 94.48% ======================================= Files 28 28 Lines 5780 5783 +3 Branches 1071 1071 ======================================= + Hits 5461 5464 +3 Misses 193 193 Partials 126 126 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.