Closed openvmp closed 1 month ago
@openvmp thanks, what is the background of this fix? How can I reproduce the issue and can a test be added?
I was trying to use CadQuery to render models for PartCAD.org. Specifically this model: https://partcad.org/repository/assembly/robotics/multimodal/openvmp/robots/don1:robot
It was larger than 1GB back then. And CadQuery was crashing on some triangle. It was too much for me to find which one and why. I stopped using CadQuery for that purpose, so it's impossible to investigate any further now.
Could you share this model as a .brep
file?
Give me some time to add this export feature and to try reproducing the crash (I operate on much smaller models now).
@openvmp I think I found a MRE:
cq.Face.makePlane(1e-9,1e-9).tessellate(1e-3)
Yes, me too.
@jmwright are you OK with merging this PR?
@adam-urbanczyk +1 to merge
Thanks @openvmp !
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1541 +/- ## ========================================== + Coverage 94.48% 94.86% +0.38% ========================================== Files 28 28 Lines 5780 6228 +448 Branches 1071 1262 +191 ========================================== + Hits 5461 5908 +447 Misses 193 193 - Partials 126 127 +1 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.