search

CadQuery / cadquery

A python parametric CAD scripting framework based on OCCT
https://cadquery.readthedocs.io
Other
3.15k stars 289 forks source link

Add missing "!" in examples doc #1545

Closed danielsan80 closed 6 months ago

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.48%. Comparing base (ff83f99) to head (a6173e9). Report is 3 commits behind head on doc_update.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## doc_update #1545 +/- ## ============================================== + Coverage 94.44% 94.48% +0.04% ============================================== Files 28 28 Lines 5774 5783 +9 Branches 1070 1071 +1 ============================================== + Hits 5453 5464 +11 + Misses 194 193 -1 + Partials 127 126 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jmwright commented 6 months ago

Thanks @danielsan80

I think you need to set your branch to merge into master rather than the outdated doc_update branch. If you look at the "Files Changed" tab, you will see there are a lot more changes than the one commit you made on your fork.

adam-urbanczyk commented 6 months ago

Thanks indeed, please reopen as a PR to master.