search

CadQuery / cadquery

A python parametric CAD scripting framework based on OCCT
https://cadquery.readthedocs.io
Other
3.15k stars 289 forks source link

Fix Assembly Location handling when applied at top level #1595

Closed lorenzncode closed 2 months ago

lorenzncode commented 4 months ago

Fixes #1594

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.92%. Comparing base (9ee703d) to head (a690fa8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1595 +/- ## ======================================= Coverage 94.91% 94.92% ======================================= Files 28 28 Lines 6259 6263 +4 Branches 1271 1273 +2 ======================================= + Hits 5941 5945 +4 Misses 192 192 Partials 126 126 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adam-urbanczyk commented 2 months ago

@lorenzncode we need to get this merged, but do you have any thoughts/updates on the comments above?

lorenzncode commented 2 months ago

@lorenzncode we need to get this merged, but do you have any thoughts/updates on the comments above?

Yes, I'll comment later today. Please hold any merge for now.

adam-urbanczyk commented 2 months ago

Thanks!

adam-urbanczyk commented 2 months ago

Superseded by #1623