search

CadQuery / cadquery

A python parametric CAD scripting framework based on OCCT
https://cadquery.readthedocs.io
Other
3.15k stars 289 forks source link

Return False on Vector comparison with non-Vector #1610

Closed lorenzncode closed 3 months ago

lorenzncode commented 3 months ago

See cadquery/CQ-editor#441

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.86%. Comparing base (33f72d2) to head (9eeccf8). Report is 10 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1610 +/- ## ======================================= Coverage 94.86% 94.86% ======================================= Files 28 28 Lines 6231 6231 Branches 1264 1264 ======================================= Hits 5911 5911 Misses 193 193 Partials 127 127 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adam-urbanczyk commented 3 months ago

Looks good, simple fix so I'll merge with one review. Thanks @lorenzncode !