search

CadQuery / cadquery

A python parametric CAD scripting framework based on OCCT
https://cadquery.readthedocs.io
Other
3.27k stars 295 forks source link

Workplane.__add__ raises ValueError instead of returning NotImplemented #1693

Open 0xorial opened 1 month ago

0xorial commented 1 month ago

From python docs:

If one of those methods does not support the operation with the supplied arguments, it should return NotImplemented.

It currently just calls .union(), which leads to raising a ValueError()

adam-urbanczyk commented 1 month ago

What is exactly the problem?