search

CadQuery / cq-cli

Command Line Interface for executing CadQuery scripts and converting their output to another format.
Apache License 2.0
22 stars 7 forks source link

cleanup unused vars and remove unnecessary "dest" from parser.add_argument() #22

Closed justbuchanan closed 1 year ago

justbuchanan commented 1 year ago

The dest argument just changes the name of the "key" in the return value args in args = parser.parse_args(), so it isn't necessary to specify it unless it's different than the flag name.

jmwright commented 1 year ago

@justbuchanan I set the gltf test up to be skipped for now (with an annotation of why) so that we can move forward on some of this work you are doing. Please update your branch(es), which should fix the test failures.

jmwright commented 1 year ago

@justbuchanan Are you ready for this to be merged?

justbuchanan commented 1 year ago

Yeah this should be good to go.