CadQuery / ocp-build-system

A system to build Python wheel PyPI packages for OCP.
Apache License 2.0
8 stars 11 forks source link

Revert change to `def try_unmangle` #27

Closed jdegenstein closed 1 month ago

jdegenstein commented 7 months ago

The change to try_unmangle caused the cadquery tests to not pass against the prior build of cadquery-ocp. I believe the resulting windows wheels were missing some of the VTK libraries, and as a result were ~56MB instead of the usual ~80MB or so.

This PR restores the prior lines in this function.

jmwright commented 1 month ago

@jdegenstein Is this still in progress, or can be close it?

jdegenstein commented 1 month ago

I am going to close this for now until we make more progress on the VTK build, it is unclear if it will be needed at this point.