search

CadQuery / ocp-build-system

A system to build Python wheel PyPI packages for OCP.
Apache License 2.0
8 stars 11 forks source link

Strip OCP .so in linux wheel builds. #38

Closed fischman closed 1 month ago

fischman commented 2 months ago

Addresses https://github.com/CadQuery/ocp-build-system/issues/33.

Test run in https://github.com/fischman/ocp-build-system/actions/runs/10912189440 has generated artifacts (linux wheels) showing the smaller OCP .so.

fischman commented 1 month ago

@jmwright WDYT?

jmwright commented 1 month ago

@fischman I do see a size decrease for Linux relative to this build. Are you ready for this to be merged? We still need to fix the VTK wheels before doing another release, but at least this will be in place.

fischman commented 1 month ago

@jmwright yes I think this is ready for merging. Not sure what you mean about fixing the vtk wheels, but guessing it's something unrelated to this PR, just affecting the timing of the next release?

jmwright commented 1 month ago

Not sure what you mean about fixing the vtk wheels, but guessing it's something unrelated to this PR, just affecting the timing of the next release?

Correct, it's not related to this PR. Thanks for the work on this @fischman . I'll trigger a build after this is merged for anyone who wants to download the smaller wheels directly and use them.

jmwright commented 1 month ago

First build in CI with strip run on it: https://github.com/CadQuery/ocp-build-system/actions/runs/11238585234