search

CadQuery / pywrap

C++ binding generator based on libclang and pybind11
Apache License 2.0
30 stars 12 forks source link

GeomLib_Tool Parameter result U is inaccessible #45

Open voneiden opened 2 years ago

voneiden commented 2 years ago

The current OCP GeomLib_Tool.Parameter_s function stores the computed result in the 4th reference argument U and returns a bool indicating success.

https://github.com/CadQuery/OCP/blob/036b08c136528fecb6df570453be218df0ed72f6/opencascade/GeomLib_Tool.hxx#L51

Return value should probably be Tuple[bool, float] or something along those lines.

voneiden commented 2 years ago

In the draft PR #46 I've presented one approach. Any thoughts on if this is worth pursuing further? If yes, I can volunteer to try to dig out if this impacts cadquery codebase in any way.

voneiden commented 2 years ago

Also I suppose if we do pursue this, the solution should support any return value, not just a hardcoded Standard_Boolean?

adam-urbanczyk commented 2 years ago

Pls open the issue in the OCP repo.

sob., 2 lip 2022, 17:35 użytkownik Matti Eiden @.***> napisał:

Also I suppose if we do pursue this, the solution should support any return value, not just a hardcoded Standard_Boolean?

— Reply to this email directly, view it on GitHub https://github.com/CadQuery/pywrap/issues/45#issuecomment-1172917289, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADKVOYTI4YGYQ6ZTWHJSK5TVSBOVJANCNFSM52O3QN7A . You are receiving this because you are subscribed to this thread.Message ID: @.***>