search

CadQuery / sphinxcadquery

An extension to visualize CadQuery 3D files in your Sphinx documentation
BSD 3-Clause "New" or "Revised" License
14 stars 4 forks source link

added option for no grid #29

Closed shimwell closed 3 years ago

shimwell commented 3 years ago

This PR adds the ability to not display a grid as discussed in #12

There is also a test added to the CI and a new example in the readme

Peque commented 3 years ago

@Shimwell Left a couple of comments for your consideration. Also, I would prefer the commit title to be Add option for no grid (imperative, with capital letter). :innocent:

Apparently, I could merge this pull-request right now, but the CI pipeline has not passed (and it is not showing). Do you know which configuration is needed to make pipelines mandatory to pass? It can be considered in a new pull-request, and a new issue can be created to deal with that. :blush:

shimwell commented 3 years ago

I think the CI pipe line doesn't run from forks by default but this can be enabled https://docs.github.com/en/github/administering-a-repository/disabling-or-limiting-github-actions-for-a-repository

I think you can make the master branch protected in the github settings "After enabling required status checks, all required status checks must pass before collaborators can merge changes into the protected branch." https://docs.github.com/en/github/administering-a-repository/about-protected-branches#require-status-checks-before-merging