search

CadQuery / sphinxcadquery

An extension to visualize CadQuery 3D files in your Sphinx documentation
BSD 3-Clause "New" or "Revised" License
14 stars 4 forks source link

Error with upcaseTokens in pyparsing #35

Closed shimwell closed 2 years ago

shimwell commented 2 years ago

I am just seeing a few errors using SphinxCadQuery in ReadTheDocs.

I notice a new version of PyParsing was recently released on January the 21st

I'm wondering if it is related to changes in the PyParsing API https://github.com/pyparsing/pyparsing/blob/938f59d183ca790e41a1d995aa3d3e995df2fb19/CHANGES#L669-L670

The error is .... and the full error can be seen here

Could not import extension sphinxcadquery.sphinxcadquery (exception: cannot import name 'upcaseTokens' from 'pyparsing' (/home/docs/checkouts/readthedocs.org/user_builds/paramak/conda/156/lib/python3.8/site-packages/pyparsing/__init__.py))

I can look into this issue and try a PR

Peque commented 2 years ago

@shimwell Thanks for reporting this issue!

PyParsing is not a dependency of SphinxCadQuery, so maybe this is unrelated to SphinxCadQuery?

Anyway, if you find out more about this issue and/or want to contribute a PR, that would be very welcome! :blush:

shimwell commented 2 years ago

I did a little digging and you are right this error is not caused by sphinxcadquery. I guess error message just mislead me a bit

Moving the readthedocs build from caquery 2.1 to cadquery master version fixed the issue.

So seeing as this is not a sphinxcadquery issue and I've found a work around I will close this issue now. Sorry for the false alarm

Peque commented 2 years ago

@shimwell No problem, and thanks for the reporting! :blush: