search

Cadair / parfive

An asyncio based parallel file downloader for Python 3.8+
https://parfive.readthedocs.io/
MIT License
51 stars 24 forks source link

Add automatic retry option #119

Open dreamflasher opened 1 year ago

dreamflasher commented 1 year ago

It would be great if you could add a flag to configure the number of retries in case a download fails.

Cadair commented 1 year ago

Hi 👋

Thanks for the issues, I am on family leave at the moment so I can't promise anything will get addressed quickly.

There is currently only explicit retry support by calling the Downloader.retry method, so you could cook up a wrapper which does this if there are errors on the results object.

dreamflasher commented 1 year ago

Congratulations and I wish you all a lovely time together! I am glad to hear that you're only temporarily away from the project, and for the best reason :)

So are you in principle open for PRs?

Cadair commented 1 year ago

Thanks!

So are you in principle open for PRs?

I am almost always in favour of PRs, as long as they don't add things which are complex to maintain (which I don't think this would) as I already struggle to find as much time for this project as I would like 😄

dreamflasher commented 1 year ago

@Cadair Hope you are enjoying your family time! How long do you currently plan to be on family leave? :)

Cadair commented 1 year ago

Hey, I am back at work at least part time, just been trying to catch up.

I put a comment on #127 is there anything else that needs my attention?! :grinning:

dreamflasher commented 1 year ago

Welcome back! That's fantastic! Let me catch up :)