Cadair / parfive

An asyncio based parallel file downloader for Python 3.8+
https://parfive.readthedocs.io/
MIT License
50 stars 24 forks source link

fix aiohttp redirect #126

Closed dreamflasher closed 1 year ago

dreamflasher commented 1 year ago

Closes https://github.com/Cadair/parfive/issues/125

codecov[bot] commented 1 year ago

Codecov Report

Base: 89.87% // Head: 89.87% // No change to project coverage :thumbsup:

Coverage data is based on head (77d0810) compared to base (2aa5790). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 77d0810 differs from pull request most recent head 34fb61a. Consider uploading reports for the commit 34fb61a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #126 +/- ## ======================================= Coverage 89.87% 89.87% ======================================= Files 5 5 Lines 622 622 ======================================= Hits 559 559 Misses 63 63 ``` | [Impacted Files](https://codecov.io/gh/Cadair/parfive/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stuart+Mumford) | Coverage Δ | | |---|---|---| | [parfive/downloader.py](https://codecov.io/gh/Cadair/parfive/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stuart+Mumford#diff-cGFyZml2ZS9kb3dubG9hZGVyLnB5) | `89.10% <ø> (ø)` | | | [parfive/config.py](https://codecov.io/gh/Cadair/parfive/pull/126?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stuart+Mumford#diff-cGFyZml2ZS9jb25maWcucHk=) | `97.77% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stuart+Mumford). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Stuart+Mumford)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dreamflasher commented 1 year ago

making the Optional explicit will also allow to auto-merge this: https://github.com/Cadair/parfive/pull/118