search

Cadair / parfive

An asyncio based parallel file downloader for Python 3.8+
https://parfive.readthedocs.io/
MIT License
50 stars 24 forks source link

Add typing to utils #139

Closed dstansby closed 5 months ago

dstansby commented 11 months ago

Because apparently I type for fun now?

codecov[bot] commented 11 months ago

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.20%. Comparing base (3b049c5) to head (e8e09f8). Report is 5 commits behind head on main.

:exclamation: Current head e8e09f8 differs from pull request most recent head 4471513. Consider uploading reports for the commit 4471513 to get more accurate results

Files Patch % Lines
parfive/utils.py 96.15% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #139 +/- ## ========================================== - Coverage 90.23% 90.20% -0.04% ========================================== Files 5 5 Lines 635 643 +8 ========================================== + Hits 573 580 +7 - Misses 62 63 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Cadair commented 11 months ago

Other than the fact that the mypy ci is angry it looks good.