search

Cadair / parfive

An asyncio based parallel file downloader for Python 3.8+
https://parfive.readthedocs.io/
MIT License
51 stars 24 forks source link

Add callbacks for ftp downloads #150

Closed samaloney closed 7 months ago

samaloney commented 7 months ago

127 didn't add the callback for ftp downloads this PR adds them.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.51%. Comparing base (3b049c5) to head (2094a0a). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #150 +/- ## ========================================== + Coverage 90.23% 90.51% +0.28% ========================================== Files 5 5 Lines 635 654 +19 ========================================== + Hits 573 592 +19 Misses 62 62 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Cadair commented 7 months ago

Thanks a lot @samaloney :rocket:

The windows test fail seems real?

samaloney commented 7 months ago

Yea I assumed since it didn't have the @pytest.mark.allow_hosts(True) decorator it wouldn't be able to download but it seem like it can. I can either mock something from aioftp to raise an error or make up a non-existent ftp url so it will fail?