search

Cadair / parfive

An asyncio based parallel file downloader for Python 3.8+
https://parfive.readthedocs.io/
MIT License
50 stars 24 forks source link

Improve repr of `Results`, remove files from disk if download errors before completing and add `max_splits` as a keyword argument to `Downloader` #76

Closed nabobalis closed 2 years ago

nabobalis commented 2 years ago

Going to see what I can do about the repr.

codecov[bot] commented 2 years ago

Codecov Report

Merging #76 (7902dc9) into main (bd16c83) will increase coverage by 0.29%. The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   91.52%   91.82%   +0.29%     
==========================================
  Files           4        4              
  Lines         425      477      +52     
==========================================
+ Hits          389      438      +49     
- Misses         36       39       +3
Impacted Files Coverage Δ
parfive/utils.py 87.60% <85.71%> (-0.52%) :arrow_down:
parfive/downloader.py 95.28% <97.05%> (+0.43%) :arrow_up:
parfive/results.py 78.26% <100.00%> (+3.90%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd16c83...7902dc9. Read the comment docs.

nabobalis commented 2 years ago

Maybe better now?

Cadair commented 2 years ago

@nabobalis If you wake up before I manage to fix this, can you debug this damned windows failure?!

nabobalis commented 2 years ago

@nabobalis If you wake up before I manage to fix this, can you debug this damned windows failure?!

I assume you fixed it since its passing now.