search

Cadair / parfive

An asyncio based parallel file downloader for Python 3.8+
https://parfive.readthedocs.io/
MIT License
51 stars 24 forks source link

Remove the default download timeout of 5 minutes for a single file #81

Closed Cadair closed 2 years ago

Cadair commented 2 years ago

Also close the request which gets the headers before opening new ones when transferring data.

codecov[bot] commented 2 years ago

Codecov Report

Merging #81 (7188fa8) into main (95db21b) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   89.64%   89.64%           
=======================================
  Files           4        4           
  Lines         425      425           
=======================================
  Hits          381      381           
  Misses         44       44
Impacted Files Coverage Δ
parfive/downloader.py 91.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95db21b...7188fa8. Read the comment docs.

dstansby commented 2 years ago

Maybe closing the original request will solve https://github.com/Cadair/parfive/issues/65 ??

Cadair commented 2 years ago

We can but hope that it helps 65. It should close the connection eventually i.e. when the whole file has transferred anyway.